Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change TLP Indicator Field Default Value #30428

Merged
merged 8 commits into from
Oct 28, 2023
Merged

Change TLP Indicator Field Default Value #30428

merged 8 commits into from
Oct 28, 2023

Conversation

BEAdi
Copy link
Contributor

@BEAdi BEAdi commented Oct 26, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CRTX-95443, https://jira-dc.paloaltonetworks.com/browse/XSUP-29338
I've noticed this is related to an effort that was done 3 years ago #8984. The empty option was removed later.

Description

Added an empty option to TLP color that will be the default option, in order to let the user not to choose a TLP value.

Must have

  • Tests
  • Documentation

@BEAdi BEAdi requested a review from yuvalbenshalom October 26, 2023 06:55
@BEAdi BEAdi self-assigned this Oct 26, 2023
Copy link
Contributor

@yuvalbenshalom yuvalbenshalom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, just see my suggestion.

Packs/CommonTypes/ReleaseNotes/3_3_88.md Outdated Show resolved Hide resolved
@BEAdi BEAdi merged commit 790a436 into master Oct 28, 2023
12 checks passed
@BEAdi BEAdi deleted the empty_tlp branch October 28, 2023 21:09
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* add empty option

* update RN

* Update Packs/CommonTypes/ReleaseNotes/3_3_88.md

Co-authored-by: yuvalbenshalom <[email protected]>

---------

Co-authored-by: yuvalbenshalom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants